Valentin Maerten comments

Results 79 comments of


                                            Valentin Maerten

refactor: Re-organize node loading code to make it easier to follow

Hey @pbitty ! Thanks for your contribution! Like @andreynering, I like the idea, I find this more readable. Can you also modify the PR title to follow Conventional Commits? because...

refactor: Re-organize node loading code to make it easier to follow

Thanks!

Feature: matrix support

I totally agree. I would add this is implemented like that in Github action and it works well

Make `sources:` respect a new `.taskignore` file, similar to `.gitignore`

Hey! I think `.taskignore` is a good idea! I am not in favor reading .`gitignore`

Task-level vars are ignored during 'requires' evaluation

What is your use case for this? Since `FILE_LEVEL` will always be defined, why would you include it in `requires`?

feat: add `isWSL` function to detect if Task is being ran on WSL

I like the idea @andreynering

feat: add override as an option to flatten

@pd93 I agree with you about the confusion but it's not my main concern. If we consider one root taskfile that includes two taskfiles, both flatten but one override and...

fix: ROOT_TASKFILE when Entrypoint is not set

I thought put a default value here ```golang entrypoint := flags.Entrypoint if entrypoint == "" { entrypoint = "Taskfile.yml" } ``` but it would break ```golang func getDefaultDir(entrypoint, dir string)...

docs: add since badge

I asked to my UI / UX design. she said it's good (regarding colors and margin)

docs: add since badge

I like the idea of versionning our docs. We can use docusaurus to do that! @andreynering what is your thought about this ?