Vitalik Marincenko

Results 7 issues of Vitalik Marincenko

when pushing new branch and this branch does not exist in origin yet Im getting this error: fatal: The current branch has no upstream branch.To push the current branch and...

bug

**Please only fill in the information you want to update for your token.** Token Name: Verse Token Symbol: VERSE Decimals: 18 Polygon Address: https://polygonscan.com/token/0xc708d6f2153933daa50b2d0758955be0a93a8fec Ethereum Address: https://etherscan.io/token/0x249ca82617ec3dfb2589c4c17ab7ec9765350a18 Logo URI (svg):...

https://github.com/wise-foundation/wise-token-contracts/blob/fe975b5f065d020ab3af065679f5c7bb738e1d1a/contracts/WiseToken.sol#L180-L182 must exclude UNISWAP_PAIR token

minor, affecting only `checkStakeByID` external view https://github.com/wise-foundation/wise-token-contracts/blob/fe975b5f065d020ab3af065679f5c7bb738e1d1a/contracts/StakingToken.sol#L611 if stake is ended pre-maturely on first/second day and there is no reward generated yet the function will try to continue calculating reward...

enhancement

https://github.com/wise-foundation/wise-token-contracts/blob/fe975b5f065d020ab3af065679f5c7bb738e1d1a/contracts/Helper.sol#L170 in scenario when user closes pending stake (same day as creation) this will impact the views as it will return eventually false, even though the stake will never get...

enhancement

https://github.com/wise-foundation/wise-token-contracts/blob/fe975b5f065d020ab3af065679f5c7bb738e1d1a/contracts/Helper.sol#L162 if the stake gets closed pre-maturely eventually this expression will return `true` once the `_currentWiseDay()` has reached the `finalDay` which will affect `checkMyStakeByID()` return information for UI, not critical...

enhancement

https://github.com/wise-foundation/wise-token-contracts/blob/fe975b5f065d020ab3af065679f5c7bb738e1d1a/contracts/Declaration.sol#L170-L182 it is possible to refactor or get rid of one of the fields in the Stake structure, as `isActive` can be determined by `closeDay` zero - active non zero...

enhancement