Vignesh Mohankumar

Results 21 comments of Vignesh Mohankumar

We're trying to create a separation between the external API and the implementation details. Ideally, we should be able to switch the internal state management without any breaking changes. The...

We are just concerned with supporting these use cases if we ever decide to switch our internal data respresentations. If we decide to change the store in any way that...

Hey @benbriggs! I am hitting this issue as well with using the current versions of `draft-js`, `draft-convert` and `draft-js-image-plugin`. Is there a current way to solve this issue? If the...

I think it best to hold off on this for now. The other PR that forces `npx deduplicate` is probably gonna get more of the benefits regardless.

Gonna hold off on this until later because need to write up a doc explaining it for the team

This PR has a lot of features at once, could we split it up into... - Update the FeatureFlagModal vh - Add new Nav styled with no children - Add...

https://github.com/Uniswap/interface/pull/4019#pullrequestreview-1036140730

Yes I see, I need to handle Pools page specifically it seems

Could you confirm that you added the necessary `peerDependencies`? They can be found in the `package.json` of each module.

We've updated our formatting helpers and this is now handled 👍