Vitali Lovich

Results 180 comments of Vitali Lovich

Grr.. I'm working with binaries that don't have any fallback and only have io_uring as a backend...

Yeah, I think a real `copy_file_range` implementation is required. Many filesystems these days support reflinks which `copy_file_range` would take advantage of while splice would generate a copy. ``` copy_file_range() gives...

cc @harrishancock for visibility.

I might be misunderstanding what you're saying, but i don't think that would work because xsendfile passes the file directly to the OS which sends it to the socket. Meaning...

Maybe I wasn't clear, but I definitely wasn't expecting this to be taken as is (as you point out & the blog post mentions, there's all sorts of problems with...

done I think?

nm - google code stuff is good for now (don't have time to work on this ATM).

Unfortunately I don't have a Windows dev environment handy. If you want to submit a fix or update the AppVeyor config to cache/publish artifacts I'll accept the contribution.

While fsnotify and inotify backends use os.walk, the Windows backend does not. How could this be added to the windows backend?

I see. Wouldn't overflows just be a checked_sub/checked_add if you want to enforce panic (slightly slower in optimized builds) or just normal math & leave it to be the users...