Vitali Lovich
Vitali Lovich
Technically `readAtLeast` could be more cleanly added as an optional dictionary to `ReadableStreamBYOBReader`'s `read` rather than as a standalone function. I.e. ``` ({done, value} = await read(buffer, {minBytes: 100}); ```...
Another one is `intersection`: ``` z.discriminatedUnion('method', [ z.intersection( z.object({ 'method': 'get' }), getSchema, ), z.intersection( z.object({ 'method': 'put' }), putSchema, ), ]) ```
That one can almost be solved by using `.merge` instead of `.intersection` but that's not always possible. `.union`/`.or` also poses a challenge.
I think the fix is this: ``` while (parts.length) { await fs.rmdir(path.join(bucketPath, ...parts)).catch(err => { if (err.code !== 'ENOENT' && err.code !== 'ENOTEMPTY') throw err; parts.length = 0; }); parts.pop();...
Hmm... I'm not entirely certain I understood what that comment means. Are you saying to use Node's Request/Response objects directly rather than the undici implementation? Or are you saying to...
FWIW Sinon.JS is only mildly better. I can't tell if it's undici now or Miniflare, but even with Sinon.JS fake timers, a second request to a Durable Object in Miniflare...
Just hit this writing e2e tests for Cloudflare R2. We don't send `accept-encoding` but we arrange for the gzipped response to be served with `cache-control` `no-transform`. We want to make...
Because we're using `fetch` and not `undici.request`. I think `undici` does have a bug here because the response has `cache-control: no-transform` set but `undici` is choosing to decompress it anyway...
ez-rpc-test is 100% failing so I suspect this is probably some kind of Wine-specific issue, but might be pointing to a subtle bug that exists even on Windows. ``` c++/src/capnp/ez-rpc-test.exe...
Not a conclusive test but this microbenchmark (https://quick-bench.com/q/FZzvXcQ1f1eO9_WMCmtBr91QB68) seems to indicate no performance difference on whatever cloud machine it ends up getting run on.