vlimant comments

Results 112 comments of


                                            vlimant

contribution and maintenance simplification

the heart of the review (HEPML.bib, HEPML.tex, README.md) can be generated from a yaml of the format provided earlier. one can use a framework, if one wants, but the suggestion...

change Selector from bit pattern to bit number for the pattern

assign xpog

change Selector from bit pattern to bit number for the pattern

please test

change Selector from bit pattern to bit number for the pattern

@sscruz cherrypick done. I'll try to update #38948. looks cumbersome to do cross-cherrypicking thus far

change Selector from bit pattern to bit number for the pattern

@jpata see 739829a771ed8ea6c916c32bd2bf5b0fa84ba1be

Problem parsing the enum in reco::Muon::Selector

`CPPUNIT_ASSERT_EQUAL(StringToEnumValue("MvaIDwpTight"),long(reco::Muon::MvaIDwpTight)); ` is a way to produce an error, from CMSSW_12_4_4 The issue seems to be that the parser casts the enum to int before recasting to any other value,...

Problem parsing the enum in reco::Muon::Selector

BTW @mariadalfonso, as we were discussing, the parser for muon was partially broken even before, when `LowPtMvaMedium = 1UL

Introduced new era for 2015 opendata nanoaod processing

isn't the rational that this change is only needed un 10.6 to be able to have a nano version for the 2015 opendata samples ?

Introduced new era for 2015 opendata nanoaod processing

looking twice at this, indeed, it could/should also be in master. @snehavireshwardixit are you able to make the same PR against master using a different branch ?

change Selector from bit pattern to bit number for the pattern [12.5]

@smuzaffar is the a “please patch” command that we could have to push the patch as a PR to my branch?