Vladislav Shub

Results 10 comments of Vladislav Shub

I think this could add a lot of value, and clean our code as well.

> @vladshub I think the challenge and where we need to think about the correct abstractions is how we bridge the conceptual gap between rabbit and kafka in respect to...

@rhinof also I was thinking about a transport registry which should look like the `database/sql` implementation in go ```go import "github.com/wework/grabbit/gbus" import _ "github.com/vladshub/grabbit-kafka" . . . ``` This way...

@rhinof , you are right that is why my suggestion is to start with just moving and abstracting away our current rabbit implementation, once it's in one place we can...

> @vladshub wouldn't it be easier to de-dup when publishing from the transactional outbox rather than when consuming the message? @rhinof we can but if we do that we can't...

@rhinof & @adiweiss can you please re-review?

Hi @FRosner I was away for a long weekend and just now got back to it... Testing it now and by the end of day will give you an answer...

@p-originate Thanks I'll check it... didn't see it until now.

Looks like it's working please tell me if you still have an issue? ``` ruby-2.1.1/bin/ruby -S rspec ./spec/api/country_spec.rb ./spec/geoip2_spec.rb [Coveralls] Set up the SimpleCov formatter. [Coveralls] Using SimpleCov's default settings....

@p-originate, @abrambailey Sorry for the long response (didn't notice that there are updates here) We don't use Rash in our gem... The Rash gem seems to be deprecated and have...