Vladimir Yakovlev

Results 285 comments of Vladimir Yakovlev

> i guess i missed it then. Been using it for 2 years and no upgrade has shown any issues. I was not exactly correct since #107 and #138 were...

I'd prefer the package moves to v1+ versioning as when I run `yarn upgrade-interactive --latest` and see red items I would normally go to package's changelog and review the breaking...

Fair enough. Still would prefer the issue to remain open as maybe someone will make a PR one day. I just disabled the vacuuming call as that should be ok...

@localvoid I'm considering converting [InvertedIndexNode](https://github.com/localvoid/ndx/blob/2a2d19cd44bf3646904ff50b5c66f35ecb03ccbe/src/inverted_index.ts#L12) class to an interface since it doesn't have any logic but used as a data container. Are there any reasons for not doing that? Serialization...

I'm going to use MessagePack serialization format, the serialized data is `Uint8Array`, arguments: - On [this](https://github.com/localvoid/ndx/blob/2a2d19cd44bf3646904ff50b5c66f35ecb03ccbe/benchmark/reddit_comments.json) data file MessagePack works 4-5x times faster than https://github.com/BridgeAR/safe-stable-stringify - Standard JSON.stringify just fails...

Ok, will go with interface then. > I think that it would be better with plain objects and simple functions, so that DCE could eliminate unused code. One step at...

@localvoid also do you think replacing `null` with `undefined` would make sense (optional fields)? In InvertedIndexNode: ``` next?: InvertedIndexNode; firstChild?: InvertedIndexNode; firstPosting?: DocumentPointer; ```

The thing is if I go with MessagePack then it will serialize undefined values as nulls, by design, which would be a sort of inconsistency. This implementation https://github.com/kawanet/msgpack-lite. So I...

Here is the PR https://github.com/localvoid/ndx/pull/5.