ndx icon indicating copy to clipboard operation
ndx copied to clipboard

[feature request] Rewrite "_vacuumIndex" in the way so it doesn't use a recursion technique

Open vladimiry opened this issue 2 years ago • 2 comments

The recursion technique is not very well scalable so the "Maximum call stack size exceeded"-like error occurs on some datasets.

vladimiry avatar Oct 11 '21 14:10 vladimiry

I agree that it should be fixed, I just haven't touched js for more than a year, so it is unlikely that I'll write code to fix this issue. Another way to avoid this issue could be to use termFilter that trims suffix. Something like (term) => term.substring(0, 24)

localvoid avatar Oct 12 '21 07:10 localvoid

Fair enough. Still would prefer the issue to remain open as maybe someone will make a PR one day. I just disabled the vacuuming call as that should be ok for my use case.

vladimiry avatar Oct 12 '21 08:10 vladimiry