Vitaly Kuprin

Results 8 comments of Vitaly Kuprin

Any updates?

> > Here is the build I'm currently personally using. Note, it also includes changes from #3562 to fix launching IEx run configurations on Elixir 1.15+, and includes #3563 to...

@FilipChalupa The cleaner approach would be to rewrite everything in types and eliminate .js files altogether. Relying on declaration files can lead to some problems with package types, as we've...

@FilipChalupa @noamr Please take a look at my patch https://github.com/noamr/use-view-transitions/pull/7 With `npm run build:packages` it should create a dist folder with .js files

@FilipChalupa Merged your changes! Good point. It's not perfect, but we are gradually improving our hook. Adding test coverage with something like Jest could potentially be our next steps

@noamr The last CI pipe has failed. Please redeploy or let's push to the master .lock files to avoid pipeline failures. Right now, it's an old version

@tanjunior The solution for this case mentioned here https://github.com/noamr/use-view-transitions/issues/6#issuecomment-1840900078 by creating another d.ts file

@tanjunior Checked your codesandbox. It seems you didn't include in tsconfig your d.ts file, that's why it's complaining of ts-error. "include": ["next-env.d.ts", "**/*.ts", "**/*.tsx", ".next/types/**/*.ts", YOUR_DTS]. Check tsconfig.json