Vladimir Kostyukov

Results 124 comments of Vladimir Kostyukov

That's right, @axel22. Just call `.close()` if you don't need the client anymore. Creating a single client instance and sharing it in your benchmark would be even better workload as...

Hey @AjayIndana! Your solution doesn't really look asymptotically optimal. I doubt it's O(n log n) as `:::` is a O(n) already.

That sounds great! Would love to see a PR that adds some.

Hello @tindzk! It's really great to hear you're migrating to Finagle. I'm actually the person who is fully responsible for that multipart API we have today. So let me give...

I think you can use [`RequestBuilder.buildFormPost(mutipart = true)`](https://github.com/twitter/finagle/blob/develop/finagle-http/src/main/scala/com/twitter/finagle/http/RequestBuilder.scala#L347) for that. See [FileElement](https://github.com/twitter/finagle/blob/develop/finagle-http/src/main/scala/com/twitter/finagle/http/RequestBuilder.scala#L30) for adding file uploads.

Multipart request streaming is also tricky in Finagle (because of both streaming and multipart are tricky in Finagle). Although, if you're feeling like build multipart request from scratch (not using...

Would be awesome if we could opt-in for original percent encoding on per route basis on a server. Most routes/endpoints don't care for path but, as mentioned in the ticket,...

Thanks @jrhee17! I played around with this idea: ```scala sb.route() .blockingTaskExecutor(Executors.newScheduledThreadPool(3), true) .build(grpcService); ``` And I think it should actually work as expected (assuming we also set the `useBlockingTaskExecutor` flag...

I agree. I think it would be nice and helpful if we can return `Map[Route, GrpcService]` from `buildPerMethod()`. Let me think more about this.

Quick update on my end: I was able to get it working using the pattern suggested by @trustin. Here is [a gist](https://gist.github.com/vkostyukov/4e6740d6b58385dea0963952aed3ba31) of what I used internally. It's very close,...