Kanishk Verma

icon location You see something that is technically sweet, and you go ahead and do it.

Results 10 comments of Kanishk Verma

boolean fields in `observability_Config` were being incorrectly omitted from the API request when set to `false`

@slevenick Can you PTAL

boolean fields in `observability_Config` were being incorrectly omitted from the API request when set to `false`

@slevenick updated the code and test .

boolean fields in `observability_Config` were being incorrectly omitted from the API request when set to `false`

Test failure for above is unrelated to the changes

boolean fields in `observability_Config` were being incorrectly omitted from the API request when set to `false`

Hi, I’ve added the test cases for both scenarios: Enabled = true and updating the other boolean fields. Enabled = false, while verifying how the other sub-fields behave. When enabled...

boolean fields in `observability_Config` were being incorrectly omitted from the API request when set to `false`

@slevenick is anything else required in this ?

boolean fields in `observability_Config` were being incorrectly omitted from the API request when set to `false`

@slevenick , Since it says wait for the major changes release. Is there any other changes required in the PR or from my side . ?

boolean fields in `observability_Config` were being incorrectly omitted from the API request when set to `false`

Got it fixed as recommmended. In future with the major version will fix the TrackWaitEventTypes as output only

boolean fields in `observability_Config` were being incorrectly omitted from the API request when set to `false`

/assign @slevenick

boolean fields in `observability_Config` were being incorrectly omitted from the API request when set to `false`

fixed the merge conflicts

boolean fields in `observability_Config` were being incorrectly omitted from the API request when set to `false`

@slevenick , Can you PTAL.