Sergei Predvoditelev
Sergei Predvoditelev
For get `id` we can make method `getId()` public. Private properties and getter/setters allow easier to make changes in the future, create readonly or writeonly properties, also in most cases...
In `getId()` id generated once (see [code](https://github.com/yiisoft/yii-bootstrap5/blob/7178c3d574b96316f6b6ca0042f3e5bd7930e312/src/Widget.php#L19)) and saved in private property. --- If getters real need (has use cases), then we should added their. --- In modern IDEs create...
Are you tested application with this translate? Seems need add language to select...
> It seems that the language selector is changing the app language, not even on the master branch Try add new language here: https://github.com/yiisoft/demo/blob/0ae717b7610d20e82039204d117790dcbc8c385b/src/Widget/LanguageSelector.php#L41
Awaiting result of experiment with new branches workflow in Yii Strings.
Ideal solution — create rector rule. Unfortunately, there is no such thing among [built-in rules](https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md).
Should we use own `InvalidArgumentException` or global `\InvalidArgumentException` will be enough?
_1. Remove such methods. Add reset*() for the rare cases it is needed._ It is will be counter intuitive: ```php $query->whe // ??? // Why IDE don't suggest method where?...
Agree with @Tigrov. Seems, in all cases to `name()` pass string value. Moreover. Seems, not need pass null to `name()`, because this method use for configure constraint once, right?
1 - 👍 2 - but we don't know order of fields in rows, also rows may contain not all fields. Seems, it's can lead to errors in user code....