Sergei Predvoditelev

Results 276 comments of Sergei Predvoditelev

``` In ClassLikeStorageProvider.php line 45: [InvalidArgumentException] Could not get class storage for yiisoft\html\tag\base\booleaninputtag Exception trace: at /projects/open-source/yiisoft/html/vendor/vimeo/psalm/src/Psalm/Internal/Provider/ClassLikeStorageProvider.php:45 Psalm\Internal\Provider\ClassLikeStorageProvider->get() at /projects/open-source/yiisoft/html/vendor/vimeo/psalm/src/Psalm/Internal/Codebase/Methods.php:240 Psalm\Internal\Codebase\Methods->methodExists() at /projects/open-source/yiisoft/html/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/Method/AtomicMethodCallAnalyzer.php:263 Psalm\Internal\Analyzer\Statements\Expression\Call\Method\AtomicMethodCallAnalyzer::analyze() at /projects/open-source/yiisoft/html/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/MethodCallAnalyzer.php:184 Psalm\Internal\Analyzer\Statements\Expression\Call\MethodCallAnalyzer::analyze() at /projects/open-source/yiisoft/html/vendor/vimeo/psalm/src/Psalm/Internal/Analyzer/Statements/ExpressionAnalyzer.php:186 Psalm\Internal\Analyzer\Statements\ExpressionAnalyzer::handleExpression()...

Run psalm (`./vendor/bin/psalm`) is OK. Run pure infecton (`./vendor/bin/infection`) is OK. Other plugins don't use. Run `./vendor/bin/roave-infection-static-analysis-plugin` throws error.

https://github.com/yiisoft/html/blob/master/src/Tag/Base/BooleanInputTag.php

Close in favor #142

> But it's a good question. Now this looks doubtful due to major changes and needs to be discussed again. Due to the renaming of public methods whose names contain...

Seems, problem here: https://github.com/yiisoft/strings/blob/b35142c92c8108a872b0ed5d83d2c62426a056dd/src/StringHelper.php#L538 It's allow escape separate symbols. For example: ``` array: ['x']['a.b']['c'] path: x.a\.b.c ``` For boost may prepare key via `explode('.', self::ARR_PATH)`.

> Either we need to check the string or remove the `non-empty string` annotation. Pattern is used in preg_match (https://github.com/yiisoft/auth/blob/master/src/Method/HttpHeader.php#L100) and throws warning when it is empty. I think, `non-empty...

Close in favor #181

These commands user can not change, so they should have unique names. So i like one of these: ``` yii-config:info yii-config:copy yii-config:rebuild ``` or ``` yii:config:info yii:config:copy yii:config:rebuild ```