Sergei Predvoditelev comments

Results 264 comments of


                                            Sergei Predvoditelev

Make logger in `ErrorHandler` optional

> NullLogger is there for this purpose Yes, optional: `private readonly LoggerInterface $logger = new NullLogger()`

Add solution providers

Looks cool! But I suggest do it in separate package.

Disable xdebug warning

Check you PHP settings. I tested with `xdebug.mode=develop` and it's work.

when the page number > total pages ,it will cause 500 error

@TiaNex-Com Can you show stack trace of error?

when the page number > total pages ,it will cause 500 error

How about this solution: https://github.com/yiisoft/data/issues/206?

Set default `$currentOrder` in `Sort` class

How to understand which order is default?

Set default `$currentOrder` in `Sort` class

Order in `Sort` object is field name + order direction, e. g. "id asc". Configuration may contains a lot of fields, how we can understand which field should use by...

Set default `$currentOrder` in `Sort` class

For set default order we should select field also, not only direction. How we can understand which field should use by default? For example, configuration: `['id' => ..., 'name' =>...

Fix HtmlRenderer to handle FriendlyException attribute safely

What is `Yiisoft\FriendlyException\Attribute\FriendlyException` ?

Adjust pretty name of closures on PHP 8.4

Closed in favor #105