error-handler icon indicating copy to clipboard operation
error-handler copied to clipboard

Make logger in `ErrorHandler` optional

Open vjik opened this issue 1 year ago • 7 comments

vjik avatar Jul 10 '24 08:07 vjik

Why?

xepozz avatar Jul 11 '24 05:07 xepozz

ErrorHandler can work without logger.

vjik avatar Jul 11 '24 08:07 vjik

There're no reasons to make it optional

xepozz avatar Sep 09 '25 09:09 xepozz

There're no reasons to make it optional

Optional always is better than a mandatory one. Creating of object is simplier.

vjik avatar Sep 09 '25 09:09 vjik

NullLogger is there for this purpose

xepozz avatar Sep 09 '25 10:09 xepozz

NullLogger is there for this purpose

Yes, optional: private readonly LoggerInterface $logger = new NullLogger()

vjik avatar Sep 09 '25 11:09 vjik

NullLogger is there for this purpose

There are no reasons to force user to provide logger in case logging in not required, even a NullLogger. Nullable param is more expected, in general.

olegbaturin avatar Sep 09 '25 14:09 olegbaturin