Vivek Khimani

Results 14 comments of Vivek Khimani

Thanks, for a quick response @romilbhardwaj! The direction I was having essential checks that can be run super quickly in ```pre-commit``` and have ```tox``` steps defined for tests and linters....

@romilbhardwaj can you help me approve the workflows blocked for the first-time contributors?

Should be ready for review contingent on the fact that the workflows pass! @romilbhardwaj

@romilbhardwaj thanks for the review! All of these comments make sense and I have a pretty good idea to fix them. I have been caught up w some school work...

Hey @Michaelvll! I am currently investigating this issue and exploring various ways to go about implementing it. Currently, ```sky show-gpus``` supports ```--cloud``` option to show GPU availability filtered by the...

Thanks, @romilbhardwaj, and @Michaelvll for the clarification. @romilbhardwaj I noticed the different naming conventions between different providers and was leaning towards your Option 2, which would include "normalizing" all of...

https://github.com/skypilot-org/skypilot/pull/1187 should be ready for review!

If I'm understanding this correctly, Semgrep uses ```Path.glob(**/*)``` for directory traversal ([reference](https://github.com/vivekkhimani/semgrep/blob/develop/cli/src/semgrep/target_manager.py#L412)). I tried to benchmark it with ```fd``` on my personal ```/Applications/Xcode.app```(~16GB, 556736 files) directory and these are the...

Ran PyCharm profiling run with @underyx and seems like there is a lot of scope for overall improvement in different methods that are currently being used. This will be a...

> It would be great to have hints on regions supported by a cloud if the user enters incorrect regions. > > For instance, for small typos, I noticed we...