Vittorio Romeo
Vittorio Romeo
To prevent a physical dependency between `sf::IpV4Address` and ``/``/``, what I would suggest is having a separate component `sf::IpV4AddressUtil` -- this is the Bloomberg philosophy that is described in Lakos'...
If we can agree on a plan, I'm happy to work on these PRs. @ChrisThrasher's tests should be merged first as a safety net.
> By returning an optional we're just imposing the error handling on the user This is a good thing IMHO. The user is forced to think *"hey, what should happen...
> Even though I'm a fan of short compile times, I agree here. Since C++ doesn't have extension methods, we need to artificially split related functionality like IpAddress and IpAddressUtils....
Good writeup. I think that the > ❌ Can be forgotten ([[nodiscard]] is needed on every single method). point in (1) is a bit overstated, as adding `[[nodiscard]]` to these...
> For example, the current approach makes `sf::Clock` bigger, even if the pause functionality is not used. @Bromeon: This is technically true, but it really is insignificant. :) --- @MetGang:...
I think it would be worthwhile to measure the compilation time impact on this PR, either with `time` or with `ClangBuildAnalyzer`.
SFMLBuildMaster: Build this please.
Consider calling this `sf::LineSegmentShape` so that we can use `sf::LineShape` for a more full-fledged line class.
@eXpl0it3r @Bromeon: would you be in favour of this PR if we rename it as `sf::LineSegmentShape` and make it clear that this is just a basic primitive over a line...