vitogit (Alvaro)

Results 27 comments of vitogit (Alvaro)

@karol-brejna-i I introduced that argument in this commit https://github.com/vitogit/pgn-tactics-generator/commit/0279b9d748eab490a5d14672e50859ac59186c30 but to be honest I don't remember why. I will vote to remove the Strict argument not sure if is that...

Good idea, also I would love to have tests. Do you have some suggestion in python? My idea is something simple like have some game.pgn files and compare the output...

I'm not sure if the results are deterministic. If I run the same input sometimes it generates less tactics. I don't have much time to go deep into this but...

Hi @bend86 thanks for the PR, I think it make sense but to be sure that we are not failing to see some edge case, can you post the pgn...

@karol-brejna-i Now that you were deep into code, what do you think of this PR?

For spaced repetition there is this project https://github.com/ArneVogel/listudy Not sure if you can get some idea