pgn-tactics-generator icon indicating copy to clipboard operation
pgn-tactics-generator copied to clipboard

Published 20 hours ago • verified publisher icon vitogit

Avoid to get an extra move when puzzle is incomplete

Open bend86 opened this issue 5 years ago • 3 comments

Example(after Ke3 next move is reported as ambiguous, but Ke3 is in the pgn): 29. Rg1 Ne2+ 30. Kd2 Nxg1 31. Ke3 0-1

We take into account the last move only if it's the player turn. Than we have: 29. Rg1 Ne2+ 30. Kd2 Nxg1 0-1

bend86 avatar Nov 25 '19 04:11 bend86

Hi @bend86 thanks for the PR, I think it make sense but to be sure that we are not failing to see some edge case, can you post the pgn of your example? or other examples

vitogit avatar Feb 25 '20 18:02 vitogit

@karol-brejna-i Now that you were deep into code, what do you think of this PR?

vitogit avatar May 22 '21 19:05 vitogit

I'll fix my previous PR (which will deepen my understanding of the code), and take a look at this afterward.

karol-brejna-i avatar May 24 '21 09:05 karol-brejna-i