vitess

vitess copied to clipboard

evalengine: support mismatched numerical types

4

## Description Found this while working on some internal stuff. The `evalengine` does not properly handle mismatched numeric types because we were not properly normalizing. E.g. an UINT8(0) would fail...

vmg

This is the general, and tracking, issue for [VEP-4](https://github.com/vitessio/enhancements/blob/main/veps/vep-4.md), [phase 3](https://github.com/vitessio/enhancements/blob/main/veps/vep-4.md#phase-3-restructuring-and-encapsulation), in which flags currently defined on the global `flag.CommandLine` in packages throughout vitess are moved simultaneously to a `pflag.FlagSet`...

ajm188

`vtexplain` fails for vindex lookup queries with duplicate / equivalent values.

1

## Description If a query contains an `IN` condition with multiple equivalent values for `lookup_unique` vindexes, `vtexplain` fails with: ``` Lookup.Map: unexpected multiple results from vindex ``` This is due...

arthurschreiber

Part of https://github.com/vitessio/vitess/issues/10697. Current flags: ``` $ git grep -E "\bflag\.[A-Z]" -- go/cmd/vtcombo/*.go go/cmd/vtcombo/main.go: schemaDir = flag.String("schema_dir", "", "Schema base directory. Should contain one directory per keyspace, with a vschema.json...

ajm188

Part of https://github.com/vitessio/vitess/issues/10697. Current flags: ``` $ git grep -E "\bflag\.[A-Z]" -- go/vt/vttablet/tabletconn/*.go go/vt/vttablet/tabletconn/tablet_conn.go: TabletProtocol = flag.String("tablet_protocol", "grpc", "how to talk to the vttablets") ```

ajm188

Switch flag definitions to be on pflag instead of flag in `package go/vt/wrangler`

1

Part of https://github.com/vitessio/vitess/issues/10697. Current flags: ``` $ git grep -E "\bflag\.[A-Z]" -- go/vt/wrangler/*.go go/vt/wrangler/vdiff_env_test.go: flag.Set("tablet_protocol", "VDiffTest") go/vt/wrangler/wrangler_env_test.go: flag.Set("tablet_protocol", "WranglerTest") ```

ajm188

Switch flag definitions to be on pflag instead of flag in `package go/vt/workflow`

1

Part of https://github.com/vitessio/vitess/issues/10697. Current flags: ``` $ git grep -E "\bflag\.[A-Z]" -- go/vt/workflow/*.go go/vt/workflow/sleep_workflow.go: subFlags := flag.NewFlagSet(sleepFactoryName, flag.ContinueOnError) go/vt/workflow/workflow_test.go: subFlags := flag.NewFlagSet(testWorkflowFactoryName, flag.ContinueOnError) ```

ajm188

Part of https://github.com/vitessio/vitess/issues/10697. Current flags: ``` $ git grep -E "\bflag\.[A-Z]" -- go/vt/withddl/*.go go/vt/withddl/withddl_test.go: flag.Parse() // Do not remove this comment, import into google3 depends on it ```

ajm188

RFC: Handle reserved/tainted connections better

3

## Problem Statement Vitess has a feature where it allows changing session-level system settings on a connection. In Vitess terminology, these connections are called tainted connections. As the connection properties...

harshit-gangal

dynamic pool implementation

10

## Description ## Related Issue(s) - https://github.com/vitessio/vitess/issues/9706 ## Checklist - [ ] "Backport me!" label has been added if this change should be backported - [ ] Tests were added...

harshit-gangal