`vtexplain` fails for vindex lookup queries with duplicate / equivalent values.
Description
If a query contains an IN condition with multiple equivalent values for lookup_unique vindexes, vtexplain fails with:
Lookup.Map: unexpected multiple results from vindex <vindex>
This is due to vtexplain "simulating" that each value of the tuple in a lookup vindex query returns a result row, but when values are equivalent (e.g. 1 and "1"), only a single row should be returned.
I tried to implement this by determining the type of the column being matched against, converting each value of the tuple to that type, and then making sure vtexplain only considers non-duplicate values.
Related Issue(s)
Checklist
- [ ] "Backport me!" label has been added if this change should be backported
- [ ] Tests were added or are not required
- [ ] Documentation was added or is not required
Deployment Notes
Review Checklist
Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.
General
- [ ] Ensure that the Pull Request has a descriptive title.
- [ ] If this is a change that users need to know about, please apply the
release notes (needs details)label so that merging is blocked unless the summary release notes document is included. - [ ] If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
- [ ] If a workflow is added or modified, each items in
Jobsshould be named in order to mark it asrequired. If the workflow should be required, the GitHub Admin should be notified.
Bug fixes
- [ ] There should be at least one unit or end-to-end test.
- [ ] The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.
Non-trivial changes
- [ ] There should be some code comments as to why things are implemented the way they are.
New/Existing features
- [ ] Should be documented, either by modifying the existing documentation or creating new documentation.
- [ ] New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.
Backward compatibility
- [ ] Protobuf changes should be wire-compatible.
- [ ] Changes to
_vttables and RPCs need to be backward compatible. - [ ]
vtctlcommand output order should be stable andawk-able.
I was unable to backport this Pull Request to the following branches: release-14.0.