Rostislav Vítek

Results 50 comments of Rostislav Vítek

I came across this issue today, it is still relevant and should be resolved IMHO

Maybe it is worth adding to all relevant phing targets? :thinking:

Hi, @Vincz, I tried it now using `master` and sadly yes, the problem is still there. We are using a similar configuration - just queries and mutations, the config is...

Hi @pk16011990, on a project, we encountered a very weird behavior - there was added a session entry in the Redis after doing a request on the storefront. The checker...

Image sizes were completely removed from the backend in https://github.com/shopsys/shopsys/pull/2924 so none of the methods is there anymore :slightly_smiling_face:

Hi, just encountered the problem described in https://github.com/nikic/PHP-Parser/issues/930. I can confirm the solution proposed here fixes the issue. What is the status of this PR, please? It has been pending...

While digging deeper into this, I would say another problem is that the whole `OrderItem::hasForcedTotalPrice()` related logic heavily counts on the fact the application uses input prices with VAT :disappointed:...

Another problematic (or questionable, at least) place is here - https://github.com/shopsys/shopsys/blob/13.0/project-base/app/tests/FrontendApiBundle/Test/GraphQlTestCase.php#L250 - the prices in tests are calculated using both approaches (from price with VAT and from price without VAT)....

I have one note to this, implementing the getters the way I suggested would mean duplicating the information when using `ProductDataFactory` to create a product from an existing one (typically...