Kelvin Luck
Kelvin Luck
To be more explicit in case the code sandbox is unavailable, given the following setup: https://gist.github.com/vitch/d8edb1b5d4895daf944cf5f086454d28 Where `tabManager` is `{{#let (state (type "tab-manager") this.model) as |tabManager|}}` the following code works...
Yeah - I meant to mention that we'd considered that. The same folders are used to power our special historical URLs and I wanted to avoid adding special casing there......
Cool. Any preferences on a name? `optimisedFetchRevisions`? `fetchOnlyRelevantRevisions`? `speedOverAccuracy`? (naming things is hard - those are more in the vein of brainstorming than actual suggestions)
In fact, it looks like `fetchRevisions` is used by `deploy:list` as well - I guess we don't want to break it there... Looking at [the hooks documentation](http://ember-cli-deploy.com/docs/v1.0.x/pipeline-hooks/) and re-reading the...
Another possible approach is to cache the result of `fetchInitialRevisions` and manually update it post-activation rather than looping over s3 again in `fetchRevisions`... That (in combination with #119) means we're...
Cool - I'll see if I can put together some test coverage... I'm wondering about _another_ flag (maybe `disableFetchInitialRevisions` although I'm open to input on naming for all of them)...
Interesting idea... I guess we'd want a `fetchRevisionsFunc` as well. And we would want the base one to accept `until` like on this PR (otherwise people would need to recreate...
I was thinking of it more from the point of view of purity of this addon... It felt a bit like the start of a slippery slope to "too many...
Linked a small optimisation and a new approach above. ~~One thing I've just realised is that there is no way from the `context` to find out which command was run...
We've been running this branch for a while now and have seen the following: * Average deploy time down to 6.1 minutes from 10.3 minutes (for apps with a lot...