Martijn Visser
Martijn Visser
Yeah perhaps we are stepping completely over a reduction factor here. The inflow is 29 m3/s and the outflow 62 m3/s. The outflow should go down to the inflow due...
A few more observations. QNDF, TRBDF2 and KenCarp4 all have similar issues. If you reduce the tolerances you get an unstable error. ImplicitEuler does seem to produce the correct results...
Yeah I can do that next week. I think the water balance error is important to address, #1413., Not sure if `isoutofdomain` should be used for this (at least the...
Ha, we had implemented that advice but removed it when we started using `isoutofdomain`, see https://github.com/Deltares/Ribasim/pull/639/files. I'll try adding that back and see the effect. EDIT: For the test model...
Fixed by #1761.
PkgBenchmark.jl has been around for a while but doesn't seem very actively maintained. Also for [CI integration](https://juliaci.github.io/PkgBenchmark.jl/dev/run_benchmarks/#CI-Integration-1) it recommends an unmaintained package. [PkgJogger.jl](https://github.com/awadell1/PkgJogger.jl) seems like a better maintained alternative that...
~~Just want to add that it is currently the combination of node_id and node_type that needs to be unique.~~ For that combination this issue remains. Name can be duplicated.
> This is another argument for storing styling information in the geopackage We plan to do this soon: https://github.com/Deltares/Ribasim/issues/610
@Manangka closed this since the codegen failed, looks like juliaup fails to download with this. The error log this fixes is harmless, but looks scary, so I'm re-opening to see...
Even though the binary builds pass, the test binary workflows are now configured such that they have to pass before the "Make GitHub Release" can start. I tried to adjust...