Jonathan Pentecost

Results 19 issues of Jonathan Pentecost

Not sure if this is useful, but, we could add a 'dir' key to each `generate` stanza of the gunkconfig. The 'dir' key would be where the gunk package(s) are...

We are currently bundling the following proto files (in on-the-wire format) with Gunk (https://github.com/gunk/gunk/blob/a6a34422e3c601e56df150b537c629eafffc74d7/assets/assets_vfsdata.go#L20) ``` - google/api/annotations.proto - google/protobuf/duration.proto - google/protobuf/empty.proto - google/protobuf/timestamp.proto ``` Now that we download `protoc`, we...

We are missing the `cc` and `python` proto file options from https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/descriptor.proto#L318, we should add them to https://github.com/gunk/gunk/blob/master/generate/generate.go#L443.

When generating grpc for Nodejs, the documentation for grpc says to do the following: ``` grpc_tools_node_protoc --js_out=import_style=commonjs,binary:. --grpc_out=. --plugin=protoc-gen-grpc=`which grpc_tools_node_protoc_plugin` helloworld.proto ``` note the `--plugin==` This is currently possible in...

It might be handy if you could set `FileOptions` (https://github.com/golang/protobuf/blob/master/protoc-gen-go/descriptor/descriptor.proto#L318) in a `generate` section. This is possible because we concatenate an entire gunk package in a single `all.proto` proto, so...

When returning an SQS message, increment the 'NumberOfReceives' so it always contains the number of times a message has been received but not yet deleted. From the AWS SQS docs:...

Unit Tests Needed

I know there is / was still a problem with django>=1.6 and the current atomic transactions django uses. Django uses the `@transaction.atomic` around all of the admin views (https://github.com/django/django/blob/stable/1.6.x/django/contrib/admin/options.py#L1099). This...

The following was not working for me because of the way libkv handles the `path` for BoltDB ```go kv, err := libkv.NewStore( store.BOLTDB, []string{"__boltdbtest"}, &store.Config{ Bucket: "boltDBTest", }, ) ```...

This fixes an issue where "resourceKoBuildCreate" uses the result of "doPublish" as the "image_ref", but in "resourceKoBuildRead" the result of "doBuild" as the "image_ref". This causes an issue when a...