gunk icon indicating copy to clipboard operation
gunk copied to clipboard

generate: missing proto file options

Open vishen opened this issue 6 years ago • 1 comments

We are missing the cc and python proto file options from https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/descriptor.proto#L318, we should add them to https://github.com/gunk/gunk/blob/master/generate/generate.go#L443.

vishen avatar Jan 16 '19 03:01 vishen

Actually, we need to add the python_generic_services to gunk-opt. cc_generic_services and cc_enable_arenas are already in gunk-opt.

All the generic_services options are considered somewhat deprecated in favour of plugins, but we may as well continue to support them until proto finally drops the,

vishen avatar Jan 16 '19 04:01 vishen