Vishal Raj

Results 11 comments of Vishal Raj

Hello @peimanfth I am facing the exact same issue you've described above. Did you find a fix to this?

Hello @vlsi I wanted to take this up. I have raised a PR (#3295) and wanted to follow up if I'm thinking in the right direction. Based on your inputs,...

Answering the questions asked in #3170 below based on my understanding and usage of pgjdbc and as mentioned in #3170 >Should it mean they represent the same logical contents? >Should...

Okay. Fair. I wasn't aware of the nature of first 5 selects returning the string representation and subsequent ones returning the binary. (where can I look to understand this behaviour...

@vlsi I have added benchmarks. After running the benchmarks on my machine, I'm getting consistent results as below. I'm pasting results of before change and after change for comparison ```...

@vlsi I have refactored the benchmarks to as to avoid reflection and directly use ```VisibleBufferedInputStream``` The results are below: ``` Benchmark (byteArrSize) Mode Cnt Score Error Units StreamReceiveInteger.receiveInteger2Benchmark 4096 avgt...

Hey @vlsi Have implemented the proposed review changes. The benchmark results look as below: ``` Benchmark Mode Cnt Score Error Units StreamReceiveInteger.receiveInteger2Benchmark avgt 25 12248.481 ± 315.238 ns/op StreamReceiveInteger.receiveInteger4Benchmark avgt...

Hi @vlsi I've accepted the review changes suggested by you and resolved them. Is there anything I can add to this or am I missing something?

Have accomodated the changes. The benchmark results are below: ``` Benchmark Mode Cnt Score Error Units StreamReceiveInteger.receiveInteger2Benchmark avgt 25 4.829 ± 0.023 ns/op StreamReceiveInteger.receiveInteger4Benchmark avgt 25 4.846 ± 0.078 ns/op...

Will these changes need to be made for just createStatement? There are the other two methods that directly use these values as arguments (resultSetType and resultSetConcurrency) as well ``` public...