Alexey Firsov
Alexey Firsov
@thehesiod, Yes, I understand. But this test does nothing useful, it just checks that the hash has not changed. For this there are tests for the used functionality. All versions...
Who should make the decision on updating super classes? And doesn't it lead to the same situation?
@thehesiod but it is not. there is still a main class aiobotocore and aiohttp. What classes should be in this test? I will return, but I think this is an...
@thehesiod you look the changes, I returned the test
https://github.com/aio-libs/aiobotocore/pull/654/files/327b38ee3b39ec64aa4c958393197bdce6c6d35d..d227ee5fd48768fc4521d72bb8c91db83c05f370
@thehesiod @jettify Thanks for the criticism, I answered all the questions. I will make another change. Since I actively use this library in my work, I would like to help...
> sorry for delay, finally updated the doc: https://github.com/aio-libs/aiobotocore/blob/master/CONTRIBUTING.rst @vir-mir let me know what you think @thehesiod Thx! Now it became clear to me why this test is needed and...
@thehesiod Hi. I made changes according to the discussion. For the convenience of code review, I broke into commits. * return back the format code for botocore (https://github.com/aio-libs/aiobotocore/pull/654/commits/f975b6dd2e9b2fda9916f988aabe335956498f11) * removed...
This is pretty weird. I am using python3.8 and aiopg 1.0.0 in commercial production. and I didn't have this problem.
@achimnol Hey. I think this is a SQLAlchemy problem, since it seems to me that the problem is in the compilation of the query. You can check this by compiling...