Dragos Vingarzan

I agree with @deepak-git-account and in general that IETF RFC functionality should be implemented also for IMS domain. And it would be good if the P-CSCF registrar would delete all...

Errm... I think we would need a fix first :wink: ... @miconda hinted that patches would be welcomed. So to spell it out: please contribute.

The bug seems to be still in the master branch. I'm super new, but would maybe this replacement line work better? ``` var {{paramName}}Param {{dataType}} ``` This should be equivalent...

Since templates are user-replaceable, as temp solution until that PR is accepted/merged/released/etc is to read this https://openapi-generator.tech/docs/templating and then 1. extract the templates ```shell openapi-generator-cli author template -g go-server ```...

@wing328 Many many thanks for your help! I will definitely come back and help in the future! I tested with the last master and it works as expected.

@herlesupreeth Would appreciate your review here please. We can talk on IM of your choice also if you wish. Thanks!

> Hey @vingarzan > > > Normally, the IMS P-CSCF should identify the clients (UEs) by the received IP address and ports on Rx > > Can you please point...

I think this security point should be fixed even outside my use-case and optional flag. But... since I can't see tests around this code, I'm a bit afraid to go...

> I didnt understand what you mean by offloading the IPsec work to an external entity. You mean IPSec creation is done by other entity (other than ims_ipsec_pcscf module)? Yup....

> Here are my further comments. Sorry for nitpicking, but here is my two cents, I would probably issue a PR addressing the `List of non-functional fixes:` mentioned above first...