vindarel
vindarel
with-porcelain-error is now fixed in main (same as "[legit: Properly package-qualify a symbol in legit-common](https://github.com/lem-project/lem/pull/1451/commits/7057e80e5d2a6671a58b641e2d61de21ed226d7a)) and the interactive rebase is confirmed to work in main.
@anlsh I am now pessimistic, I assume the PR was too big to start with. If we don't merge this then we shouldn't touch the legit code to avoid merge...
@anlsh The PID is still found correctly (we can see output on the terminal with log:error) ```lisp (if (uiop:process-alive-p process) (let* ((output (read-line (uiop:process-info-output process))) (pidtxt (str:trim (second (str:split ":"...
it works with a root-> vcs object mapping as in ```lisp (defvar *git-projects-mapping* (make-hash-table :test #'equal) "Map a VCS project root to its VCS object. We need a single VCS...
bug found: when changing the VCS preference order, `rebase-in-progress` signals an error when it shouldn't. It's OK on main: ```lisp (case *vcs* (:git (when (uiop:directory-exists-p ".git/rebase-merge/") (let ((head (str:trim (str:from-file...
closing in favor of https://github.com/lem-project/lem/pull/1538 It was tedious because of the lack of testing, but the result is good. Thanks for doing it @anlsh and for answering my doubts. It...
Are you using Quicklisp or `str` from master? A fix was merged but in February and Quicklisp is not up to date. see https://github.com/vindarel/cl-str/pull/108/files (for https://github.com/vindarel/cl-str/issues/99)
Is it in Windows WSL? On Unix, do you have the "which" binary?
Hi yes it is IMO, I edited it after your remarks.
Wow, it's super cool :rocket: LGTM (only a minor request with the defvar)