vindarel

Results 591 comments of vindarel

No more `pad-*` compilation warnings with a newer compiler (SBCL 2.5.8).

TIL about table views. They are not documented. A commit says they initially only worked with Postgres. https://github.com/fukamachi/mito/commit/81c3ccebe6ba71a84809316872f291c33d6f1ecd

> There's no reason to have all of this dispatch logic done manually: this is a textbook case for using generic functions. Now, the thing is that generic functions need...

I have more feedback for the review to add, mostly style and a couple things you are un-doing, but let's speak about the important question: what is this fixing? (going...

> anlsh wants to merge 34 commits from [anlsh:legit-libgit2](https://github.com/anlsh/lem/tree/legit-libgit2) your branch is badly named. Also is it rebased onto main? It would help for reviewing it locally.

> Admittedly adding a parameter makes the porcelain functions slightly harder to call from the REPL: but I think you're overblowing this a bit. You can still totally bind whatever...

> > anlsh wants to merge 34 commits from [anlsh:legit-libgit2](https://github.com/anlsh/lem/tree/legit-libgit2) > > your branch is badly named bad branch name, I think it is problematic to merge it and have...

hey @anlsh I believe we are not far from merging this, do you think you could give it another look soon-ish? We are holding back in touching legit to avoid...

A rebase interactive fails with: 12: (ERROR LEM/PORCELAIN:PORCELAIN-ERROR :MESSAGE "lem/porcelain:rebase-interactively not implemented for vcs #") a quick look didn't give me the answer. In addition, the error reporting macro needs...

I can go further but now, when I want to confirm the rebase with C-c C-c: > The slot LEM/PORCELAIN-GIT::REBASE-PID is unbound in the object # so the PID wasn't...