Vincent Fugnitto

Results 149 comments of Vincent Fugnitto

@msujew before adding additional changes what do you think of such a change to improve our command typings, and potentially pick up bugs (a couple have already been fixed thanks...

> I would therefore propose the following: > > - We will take a look whether "SecondaryWindowHandler Improvement" can be fixed without additional changes to Phosphor (which is to be...

> One question regarding "SecondaryWindowHandler Improvement": Did you observe this in electron or the browser? For electron this is already known but in the browser bringing up the minimized window...

> @vince-fugnitto When an external widget is revealed by the application shell, the secondary window handler calls `focus` on the widget's external `Window`. In the browser this is sufficient to...

> Does that sound like an acceptable solution to you? @lucas-koehler if the second option works then I'd be fine with it :) Initially I had thought the best solution...

@lucas-koehler > In addition we would rename the package `secondary-windows-ui-browser-only-experimental` to highlight to potential consumers what they can expect. I don't think a rename is necessary, only a note in...

@lucas-koehler I've opened a couple of follow-up issues to track the known limitations and bugs. If you want to do the same that would be appreciated.

I did not get the UI for the validations yet, I thought the feature came straight from Monaco but I haven't been able to identify it, or it's potential implementation...

> All that's missing is some CSS for borders/coloring. Thanks for taking a look as well @msujew, it might be a little tricky using the class due to the markup...

@msujew I was able to get the styling to work from monaco itself which I always believed was the case :) the pull-request is now ready for review to anyone...