Ville Saukkonen

Results 102 comments of Ville Saukkonen

@ayrton is the check for keys even necessary to have in the library it self? Couldn't the library user handle the checks and library could just pass all the events...

@ayrton to be able to get all the keyboard events to my component and do what ever i want to do with them :) In my case i would use...

Sure, I'll fix the remaining tests :+1:

@piglovesyou I've now updated the snapshots. is there something needed besides updated snapshots? I added a mention about the schemaPlugins to the readme. It's a bit funny example since it...

I would also consider getting rid of this since schemaPlugins allows controlling optional plugins from the outside: https://github.com/piglovesyou/graphql-let/blob/88e9c52b1a0a8cd828fd3e4f5d7edd09e80a4b1c/src/lib/codegen.ts#L16-L27 and possibly the default `typescript` plugin since there's a risk for misconfiguration...

Got rid of `OPTIONAL_SCHEMA_PLUGINS` and the related logic in the last commit.

Thanks for the hint! Indeed a comment is a good workaround for this for the time being.

Good questions! I'd say that the result is close to the same what here when the request has finished: `const [result] = useGetStuffQuery(...)`. An error would also be a result....

Wow, thanks for the response! It never stops amaze me how thoroughly you answer to all the issues and ideas, it clearly tells how much you care and understand about...

@kitten came up with a bit similar need here: https://github.com/FormidableLabs/urql/discussions/2346 It's a question since I'm not sure if there is some idiomatic way to achieve what I'm trying to do...