Viktor Malík comments

Results 349 comments of


                                            Viktor Malík

Bump up the LLVM version to 19

Great work!

Add support for custom user patterns written in C

> Hello, I started working full time in July last year and afterwards completely forgot about the diffkemp at the time. Right now, I just pushed the changes I had...

Bump to C++20

Another nice feature is `std::set::contains` which can be used instead of using `.find(...)` and comparing the result with `.end()`

CI problems (429 error, cache size)

Thanks for the nice analysis! > So lately there have been problems with CI: > > 1. **429 Error when restoring kernels** > Caused by too many requests to GitHub...

Add definitions of macros to `diffkemp-out.yaml`

Yeah, it seems that there are many ways to do this. From the first glance, option 3 seems like the best but I think that we should have an in-person...

codegen: Fix segfault of CodegenLLVM::generateProbe()

Thanks for catching this problem! I believe that we need to generate the dummy probe only for cases when none of the probe attach points exists. This should fix it:...

codegen: Fix segfault of CodegenLLVM::generateProbe()

Needs rebase onto the current master. Also a CHANGELOG entry would be nice.

codegen: Fix segfault of CodegenLLVM::generateProbe()

We should also consider if this is worth another patch release. Among other things, it breaks `opensnoop.bt` on aarch64.

codegen: Fix segfault of CodegenLLVM::generateProbe()

Thanks!

Use bitcode files instead of textual in snapshots

Also needs a rebase since `cc_wrapper.py` was moved to a different directory by #387.