Viktor Malík
Viktor Malík
I didn't get a chance to review the code so far but I'm in favor of this change. There's no point in special-casing multi-value keys when we can make them...
Makes sense to me from a high-level perspective. Also agree with @ajor's proposal of the distinction between probe parts (colon-separated) and probe attributes (the new syntax). I'd say that if...
Thanks for the detailed analysis and testing @PLukas2018! I didn't have time to review the PR, yet, but I can confirm that the above is the correct set of configurations...
For some reason, the development build is not working for me. I'm getting failures during compilation. Build log: ``` $ cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug -- The C compiler identification is...
> For some reason, the development build is not working for me. I'm getting failures during compilation. > > Build log: > This is Nix development env, happens for both...
> I tested building and comparing on clean Fedora and discovered two problems. Both of these depend on how we want to use DiffKemp for local development without Nix (if...
Wow, excellent analysis @PLukas2018. I can only agree, obviously if something cannot be easily squashed, it can stay as a separate commit (with a reasonable commit message). Also if you...
Let's go :rocket: :rocket: :rocket:
> 1. The removal of comparison of `StringRef` with `equals` method. We should investigate when was the `==` operator added and use that instead of some macro and intermediate function....
Before looking in detail, I think we should split this a bit more: - the first two commits can go to a separate PR, along with the last commit -...