Vikas Agarwal

Results 12 comments of Vikas Agarwal

@patrickhulce what do you mean by `odd numbered graph issues` here?

@patrickhulce I am able to get upto this point where I can render the graph for CLS and as first graph has multiple metrices rendered, I tried to move it...

@patrickhulce did you get chance to look at this layout?

> if we flip the FCP/LCP graph above the other two then LGTM :) Yes, that also looks good and infact I tried that first. This layout I tried to...

@patrickhulce do we have any guide for how to fix unit tests for these changes? I am seeing some unit tests failing after introduction of new graph.

@patrickhulce I am just trying to run `npm run test` after my changes and it is breaking some of the existing tests.

@patrickhulce here are few of the tests (`snapshots` mostly) which are failing:

I didn't try to open diff yet as I didn't realize that I can see the diff image as well. On the second point, is there any guide how to...

@Kudja I guess if we compare the group of the audit to be `metrics`, it won't be hard coded because I think it very least probable to have change of...

@patrickhulce create PR https://github.com/GoogleChrome/lighthouse-ci/pull/784 for this issue, please let me know the feedback.