robohive icon indicating copy to clipboard operation
robohive copied to clipboard

np.product -> np.prod for np 2.0 compatibility

Open vmoens opened this issue 1 year ago • 2 comments

np.product does not exist anymore, np.prod should be used instead

vmoens avatar Jun 24 '24 09:06 vmoens

@vikashplus The CI reports this thing (I think due to an H5-numpy version mismatch)

ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

Also is branch -> dev still the right way of proposing changes in robohive?

vmoens avatar Jul 02 '24 10:07 vmoens

Seems like it. Unsure where it coming from. We don't pin to anything specific - https://github.com/vikashplus/robohive/blob/main/setup.py#L51-L67

vikashplus avatar Jul 07 '24 20:07 vikashplus