Vijay Varma

### Is your feature request related to a problem? Please describe. The documentation of [find_peaks](https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.find_peaks.html) doesn't actually explain what prominence or width mean. These sound pretty similar, and can even...

Switch to py3.9 for testing

3

We should try to resolve #7, which happens for more recent Python versions.

Actions broken

3

You should be able to fix it like this https://github.com/vijayvarma392/surfinBH/commit/fbff946117cc42d7dc55126b94ce710da174095b

We need to profile the ecc measurement code

2

Would be good to understand which part of the code is slowest, etc.

Need to be more careful in truncate_waveform_by_flow

4

https://github.com/vijayvarma392/gw_eccentricity/blob/e1e3a1dc11ecf8afac105db205bbf6cafa8fa11a/gw_eccentricity/truncate_waveform_by_flow.py#L77 Does this code first compute pericenters when getting `gwecc_object` and then recompute them again? That's very bad! Similarly, why repeat the code about retaining good extrema, and building the...

test_interface.py should test all possible use cases and optional arguments. For example, right now we only test the default [options](https://github.com/vijayvarma392/gw_eccentricity/blob/main/test/test_interface.py#L12), and have no way of guaranteeing that the options in...

Maybe we want to allow nonuniform time steps

4

There are some situations where non-uniform time steps are a very good idea: Let's say we have a long waveform (BNS length). Then having a time step of 1M throughout...