Vigya Sharma

Results 11 comments of Vigya Sharma

Excellent discussion here, with some really good ideas, and hard questions about segment replication and failover scenarios. I love the overall idea, and mostly agree with the approach being discussed...

> > Do Primaries handle searching too? > > For now, yes. This was discussed for "priority queries" (e.g., alerting use cases) where the primary would have documents available for...

In this decoupled index/search world, cluster load balancing can also be done without shard promotions and relocations. The leader could put the current primary on `standby` mode, and allocate a...

> it uses `instanceof`: https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsWriter.java#L686 Thanks for sharing that link @rmuir. Intrigued, I did a quick search for `instanceof` in the `codecs/`, and found such checks in more than one...

I see you'd already responded to a bunch of my comments. I should've refreshed my PR page. Will resolve those.

> An alternative implementation would be to add the bytes only in the `IndexOutput.close` method instead of on each method that writes bytes? It might be less error-proned, but, also...

Thanks for persisting with this @mdmarshmallow. I think we're close now, just a couple of discussion threads to resolve. This change will be super useful :)

> This implementation ignores temporary index outputs from write amplification, which I wonder whether this is correct (maybe it is, I struggle making an opinion on this question). Interesting point.....

Thanks for persisting on it @vsop-479. I think we should dig more into what has changed in Windows 11+ before we change the assert condition on this test. Does it...

I was looking at this PR since it's marked as stale by our bots. I see that we've already added the [fallback to exact search](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java#L258-L265) when `k > maxOrd()`, and...