Viktor Gal
Viktor Gal
@lambday this is now how it works that we just pass on things with prngs :) but note since https://github.com/shogun-toolbox/shogun/blob/develop/tests/unit/statistical_testing/internals/CrossValidationMMD_unittest.cc#L110 https://github.com/shogun-toolbox/shogun/blob/develop/tests/unit/statistical_testing/internals/CrossValidationMMD_unittest.cc#L94 these guys dont share a prng.... just saying... so...
@lambday i guess this is what u had in mind https://github.com/shogun-toolbox/shogun/commit/7022a56181c68af5c5f2dab33d056e55d36ba107 note that every test in CrossValidationMMD unit tests fails atm with this change, but since the only check is...
note that if i revert the change in CrossValidationMMD but keep the prng changes you've requested, there's still one test that fails: CrossValidationMMD.unbiased_incomplete
@lambday any ideas? since now we have 2 same type but separate prng seeded with the same seed... but the unit test still fails :(
@lambday any updates on this by any chance?
@bhavukkalra it's not fixed in the whole codebase. you can `git grep DotIterator` and see how it is used in some parts of the code.
i'm not so sure what you are looking for. there's an api description of DotIterator as well as if you have found where it is being used you'll see how...
the only additional information regarding this that since this issue was created those macros has been changed to function calls; see for example `REQUIRE` is `require`. for more details about...
dontdie! :)