Viktor Gal

Results 84 comments of Viktor Gal

@ashutosh-b-b you could start with that or with https://github.com/shogun-toolbox/shogun/blob/develop/src/shogun/metric/LMNN.cpp basically the idea is that you follow the CRTP pattern with IterativeMachine and move an iteration to logic into `iteration` function

agree, yeah that’s the only sensible solution atm > On 9 Mar 2020, at 09:55, Gil wrote: > > Hmm ok, so I think that either we add a #ifdef...

currently failing tests are: KMeans.minibatch_fixed_centers MeanRule.combine_matrix MalsarTraceTest.train MalsarClusteredTest.train MalsarL12Test.train NormOneTest.apply_to_vector RandomForestTest.score_compare_sklearn_toydata CARTree.comparable_with_sklearn MulticlassLibLinearTest.train_and_apply BaggingMachineTest.output_binary Math.linspace_test SGSparseMatrix.io_libsvm ROCEvaluation.one these will definitely have somewhere such a case mentioned above

@Aakash1822 i've given example in the description and there's the list of the errors failing. you need to find similar (like in the example) the classes that are being used...

@Hephaestus12 i'm not so sure where did you read about not writing cookbook pages.... yes you need to comment the sections. please check out our documentation and you'll find answers...

@festusojo123 plz read about how to submit your first PR on github (search for manual on the internet)

sorry for the late reply! first of all what is the version you are trying to use? because in develop all the `SG_UNREF` calls are gone since we switched to...

@karlnapf unfortunately that will not work....