Sebastiano Vigna

Results 188 comments of Sebastiano Vigna

After having see @techsy730 clever idea for forEachRemaining(), I think we can try to do the same here. The idea is to have a type-specific BinaryOperator class. Then we implement...

Almost. IntBinaryOp has in my mind has an apply(int, int) method, which is the one delegating to applyAsInt() if available. As usual, the method inherited from BinaryOperator delegates to the...

So, I slightly hijacked this PR in the sense that I implemented type-specific binary operators. The modifications to gencsources.sh are no longer necessary. Could you try to bring this PR...

OK, I understand a bit better now the situation. The problem is that this has to be fixed first at the _interface_ level, or open hash maps will have type-specific...

Hey, we're working for a better world—in the sense of a more readable #ifdef'ing of the code. We'll come back to this PR as soon as things are stabilized (hopefully...

So, there has been a lot of internal reworking inside fastutil, so we will need to bring this up to date with those reworking. I'm also thinking about including functions...

Urgh. I made so many changes—some mistakes slipped through. Thank you for reporting this, I'm looking into it...

That should be fixed with 6bacc8990. There were several cases in which the method was compiled in, but it wasn't necessary. I think I didn't left out any case (or...

Almost there. - To bring this in line with the overall restyling, we need to avoid #ifdef. There are several things you can use, KEYS_INT_LONG_DOUBLE, etc., but we have tried...

> Do you have some specific code lines in mind? Everything that is not explicit. `#ifdef COMPUTE`, for example. In general, no `#ifdef` (stuff like `KEYS_INT_LONG_DOUBLE` has an actual value...