Julien Viet comments

Results 1414 comments of


                                            Julien Viet

Add peer host and port info for server SslHandler (4.x)

looks good but I'd prefer use vertx type `HostAndPort` which is more suited for this internally

Add peer host and port info for server SslHandler (4.x)

@ben1222 thank you, can you port the changes to master ?

Add peer host and port info for server SslHandler (4.x)

@ben1222 it sounds reasonnable to do early november a 4.5.11 release given that there is a fair amount of issues which have been fixed

PostgreSQL: Add support for direct SSL negotiation

it might be backported

[modify repull ]get the first char from a String using charAt() directly, rather than transfer a String into char array.

just redo a new PR and close this one

SSH incompatible event loop when NativeTransport set to true

yes taht's expected, there should be some lifting project to accomodate this

SSH incompatible event loop when NativeTransport set to true

do you mind try contribute a fix for this ?

SSH incompatible event loop when NativeTransport set to true

this should be reopened in Vertx-shell project and checked against vertx 5

Better document the connection between `HttpServerRequest#path()` and `RoutingContext#normalizedPath()`

> Funny thing is that the implementation of `RoutingContext.normalizedPath()` is super simple and basically only calls to an utility method that is _not_ in Vert.x Web, but in Vert.x Core....

Zero copy file transferring (via FileRegion) is disabled for IoUring transport.

@doxlik have you tried modifying your own build of vertx to make this work ? I can see that io uring file region are created by AbstractIoUringStreamChannel#filterOutboundMessage that automatically turns...