Vin Le

Results 30 comments of Vin Le

@ChristopherDosin I will have a look :D

@PierrickVoulet P Yes that's it! Because the GoogleAdsClient is final class so I cant just mock it, I tried using an adapter but it looks ugly and redundant since it...

Hi @t-poeschl can you show your request URL and payload so I can see if there're anywrong? Maybe this commit is fixing it in the shopware core? https://github.com/shopware/platform/commit/9b82ec295ba23492f5694c77245d1f5553416a37

I'd agree with your suggestion 👍🏽 Thanks for your contribution :) The MR looks good but please add the changelog for what you have changed in the new version

Hi @ckilb Can you resolve the conflict :) after that I can merge

Hi @oliverkuehne Thanks for the feedback, I will take a deeper look into this and give my idea soon. Any other suggestion from anyone is welcome :)

Hi @okuehne The Collection have built-in getIterator() so I guess you don't need to define your own method. As for large array, I'd suggest to either chunk it into smaller...

Hi @solverat I got your intention here, if the payload is relatively small I'd just put it into the payload ```php $productRepository->create([ 'active' => true, // or $product->active ], $context);...

@solverat Hi, sounds like a good idea, I created a new issue here https://github.com/vienthuong/shopware-php-sdk/issues/23 But honestly, I don't 100% get your expectation so can you write a bit more specific...

Hi @jakub-groncki Sorry for the late response. Change the nullable to non nullable is breaking change unfortunately. By default it's all nullable so we can set all the properties with...