Vidush Singhal

Hello, By input dependent control flow I meant the inputs that are given to the model here: https://github.com/facebookresearch/dlrm/blob/97272b580a7a0d4ef98de6fdb654a442876921be/dlrm_s_pytorch.py#L893 These could all be traced but then it would require different inputs....

> Those are just hyperparameters. Hyperparameters do not change during program execution and are expected to require different traced/scripted program captures per set of hyperparameters. yes I agree. But I...

> > > Those are just hyperparameters. Hyperparameters do not change during program execution and are expected to require different traced/scripted program captures per set of hyperparameters. > > >...

Hello, I have created a PR for prim is nested here: https://github.com/llvm/torch-mlir/pull/881 I used the command: `tools/torchscript_e2e_test.sh -v --filter Prim` to test.

> Can you look at the source locations and see where this is coming from in the Python code itself? Yes I will check and get back to you.

> Hi @pashu123 thanks for pointing that out. I am actually in the process of writing the linalg lowering for the aten.embedding_bag.padding_idx op. The only other torch.operator that I see...

> Yup. I have already registered it. I'm working on a branch. Here is a draft PR. Haven't pushed the latest changes here though. https://github.com/llvm/torch-mlir/pull/1066

I added 2 manual tests for QrEmbedding and PrEmbedding modes. It was not straightforward to make artificial inputs for dlrm that would run those modes. But the code is representative...

## Review checklist for @vidsinghal ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/main/COI.md) and that: I have no COIs...