Vidip Singh
Vidip Singh
> Thanks, @vidipsingh! I assume the benchmarks are now passing on your fork? You may trigger them via the "Run workflow" button: https://github.com/vidipsingh/PyBaMM/actions/workflows/periodic_benchmarks.yml. If they work, we should be good...
> Hi @vidipsingh, from your CI log, this looks like an upstream issue. See a related issue tracked here: [networkx/networkx#7638](https://github.com/networkx/networkx/issues/7638) > > The issue has been reported in [airspeed-velocity/asv#1412](https://github.com/airspeed-velocity/asv/issues/1412) and...
> If you plan to remove this, you will also need to modify the associated tests. Before opening a PR, run the tests via `nox -s unit` to get the...
Hi @prady0t, I've updated the tests related to the cylindrical geometry removal and ran `nox -s unit` to confirm everything passes successfully. Could you kindly review the changes and let...
> Test wise it looks fine. One test was failing, so I removed the `test_cylindrical_div_convergence_quadratic` test. After that, there are no errors when running `nox -s unit`.
> The "cylindrical" finite volume tests are different from the "cylindrical" geometry, I don't know why those tests faield but they should not be removed Got it! I’ll revert the...
> looks good , thanks! Sure, anytime! Glad it's good to go.
> @vidipsingh It looks like tests are still failing here @kratman Thanks for pointing out the failing tests. When I ran the `nox -s unit` test command locally, I encountered...
> > @vidipsingh It looks like tests are still failing here > > @kratman Thanks for pointing out the failing tests. When I ran the `nox -s unit` test command...
Hi @kratman @valentinsulzer, Just wanted to follow up on this PR and check if there are any changes needed from my side. It would be great if you could review...