Vidip Singh

Results 32 comments of Vidip Singh

I am having 'npm run lint' issue. Can anyone help me in it? @sanjay-kv @chandel-aman

Hi all, Thanks for the detailed discussion on this! I agree that deprecating the "Number of electrodes in parallel" parameter in favor of using "Electrode area [m²]" sounds like a...

Hi @valentinsulzer, I've made these changes: - Ensured `surface form = "false"` and `"algebraic"` match for single-phase SPMe (`"particle phases": ("1", "1")`) by using `delta_phi = phi_s - phi_e` in...

Hi @DonnieBLT, I’ve made the changes to support timed bounties in both repositories and created the following PRs: - `OWASP/BLT`: #3932 - `OWASP-BLT/BLT-Action`: [#67](https://github.com/OWASP-BLT/BLT-Action/pull/67) Can you please review them and...

> Need to decide what to do about Ai2020 and Sulzer2019 - perhaps just scaling the electrode width. Also this will need a clear deprecation message (we could check specifically...

> Thanks for taking this on, @vidipsingh . I can't help but notice that there are a bunch of changes made here that are unrelated to this issue. Perhaps they...

> > > Thanks for taking this on, @vidipsingh . I can't help but notice that there are a bunch of changes made here that are unrelated to this issue....

@DonnieBLT Could you please review these changes? Thanks!

Hi @Saransh-cpp, @agriyakhetarpal, I’ve disabled the memory benchmarks in `asv.conf.json` that were failing due to `pympler/pympler#151`. Here’s the approach I followed: - Added `"exclude"` entries (e.g., `"memory_sims.MemSPMSimulationCCCV.*"`, `"memory_unit_benchmarks.MemSolveModel.*"`) to skip...