Victor Lin

Results 123 issues of Victor Lin

### Description of proposed changes See commit messages. ### Related issue(s) ### Testing - [ ] Checks pass - [x] ~(to be done by a Nextstrain team member) [Create preview...

## Description of proposed changes Suggested by @ivan-aksamentov [on Slack](https://bedfordlab.slack.com/archives/C01LCTT7JNN/p1699616862660499?thread_ts=1696895285.086759&cid=C01LCTT7JNN). ## Related issue(s) - Follow-up to #1704 ## Checklist - [ ] Checks pass - [ ] Consider something like...

*[from discussion forum](https://discussion.nextstrain.org/t/is-auspice-hover-over-information-display-configurable/1490)* ### Context Currently this is hardcoded, except for one entry that changes with the Color By: https://github.com/nextstrain/auspice/blob/f1f3c1c61c90c116f1ae760de27dacedc9519290/src/components/tree/infoPanels/hover.js#L412-L418 ### Description Allow customization of all entries in the dataset...

enhancement

With the adoption of TypeScript, there should be a standard way of typing props. This was explored in #1704 and we came up with these options: 1. Define each set...

_Originally posted by @jameshadfield in https://github.com/nextstrain/auspice/pull/1704#discussion_r1366231693_ > It would be better were the action of showing a second tree appropriately modified the available panels state. Beyond this PR, just noting...

_from https://github.com/nextstrain/auspice/pull/1715#discussion_r1367312799_ The [Data updated element](https://github.com/nextstrain/auspice/blob/ba7e1c20d463f69d570cd46cc00e9bd9e51d49fa/src/components/info/byline.js#L25) sometimes renders slightly lower than the other ones and I can't figure out why. Example: ![ncov/open is rendered lower](https://github.com/nextstrain/auspice/assets/13424970/e6a0eafd-835f-480e-bb2b-56a85ebf6a2d) No problem when data provenance...

bug

Redux was adopted in Auspice many years ago. Since then, Redux has developed new features to simplify usage (e.g. Redux Toolkit, hooks API). Steps from the [migration guide](https://redux.js.org/usage/migrating-to-modern-redux) (doesn't have...

## Context When working on UI changes, it's useful to previews the changes on nextstrain.org. Currently, [the process](https://github.com/nextstrain/auspice/blob/8377c4c47003468dab5b34cc02ab2d06eb952ca1/DEV_DOCS.md#test-on-downstream-repositories) is simple but it takes a long time, at least 20 minutes:...

### Context This behavior was observed in d5c77d41dfa3b7803c1699832e96135412df8aa0 and https://github.com/nextstrain/auspice/pull/1520#discussion_r1036594154. ### Description When running from an external project, there are two scenarios: 1. The project intends to build and use...

### Description of proposed changes See commit messages. I thought of these while working on #1520, but believe these changes can be made independently of the Webpack upgrade. ### Tasks...