Victor Lin

Results 123 issues of Victor Lin

### Description of proposed changes See commit messages. ### Related issue(s) Fixes the unhandled exception in #1075. ### Testing - [x] Add a test - [x] Checks pass ### Checklist...

### Description of proposed changes This adds a basic interface to enable working with metadata in a world of SQLite3. See functional test files for example usage. Implementation was pulled...

### Description of proposed changes ### Related issue(s) Follow-up to #1211 and https://github.com/nextstrain/augur/pull/966#discussion_r972433558. ### Testing - [ ] Add new tests ### Checklist - [ ] Add a message in...

_Prompted by https://github.com/nextstrain/augur/issues/1262#issuecomment-1650557226._ ### Description `export v2` (for Auspice v2) has been around for a while, and should be widely adopted at this point. There should no longer be a...

### Description of proposed changes Pyright supports some checks and type inference that Mypy does not¹. ¹ https://github.com/microsoft/pyright/blob/1.1.316/docs/mypy-comparison.md ### Related issue(s) - Based on #1244 ### Testing - [x] Pyright...

### Current Behavior When `augur.io.read_metadata()` is used on a file that has a row with a missing value, there are no warnings/errors, and columns are populated in the order of...

bug

Apply current [recommendations](https://github.com/nextstrain/augur/blob/-/docs/contribute/DEV_DOCS.md#tips-for-writing-cram-tests) to all tests: > 1. Keep cram files modular. This makes it easier to see which command is failing. > 2. Create files in the initial working...

### Background The behavior across Augur subcommands is inconsistent when it comes to date-related options. `augur frequencies` and `augur refine` will fail with an uncaught `KeyError: 'date'`, while `augur filter`...

bug

## Description of proposed changes See commit messages. ## Related issue(s) N/A ## Checklist - [ ] Checks pass - [ ] If making user-facing changes, add a message in...

## Description of proposed changes I thought of these while going through Webpack 5's [Asset Management guide](https://webpack.js.org/guides/asset-management/). Details in commits. ## Related issue(s) ## Checklist - [x] Checks pass -...